Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for format:2 transaction data #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanMacDonald
Copy link

@DanMacDonald DanMacDonald commented Aug 22, 2021

Arweave introduced a new format for transaction data but the weavemail app hasn't kept up.

Currently it is unable to view messages stored using the new transaction data format.

This PR adds support for format:2 transaction data and enables weavemail app to view messages again.

The behavior I'm observing is sometimes the weavemail transactions arrive with their txn.data field initialized and sometimes they don't. In the cases where .data is uninitialized the app isn't able to display the message. You'll see an error in the log about b64UrlToBuffer() unable to perform a .replace on the argument data because it's not a string.

This behavior is intermittent, some days the txn's have .data initialized sometimes they require .getData().

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant