Remove now unnecesary clamps

ArthurBrussee · Jan 6, 2025 · 77b7165 · 77b7165
1 parent 20374d2
commit 77b7165
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/crates/brush-train/src/eval.rs b/crates/brush-train/src/eval.rs
@@ -62,9 +62,7 @@ pub async fn eval_stats<B: Backend>(
         let gt_tensor = image_to_tensor::<B>(&ground_truth, device);
         let (rendered, aux) = splats.render(&view.camera, res, false);
 
-        let render_rgb = rendered
-            .slice([0..res.y as usize, 0..res.x as usize, 0..3])
-            .clamp_min(0.0);
+        let render_rgb = rendered.slice([0..res.y as usize, 0..res.x as usize, 0..3]);
         let mse = (render_rgb.clone() - gt_tensor.clone())
             .powf_scalar(2.0)
             .mean();

diff --git a/crates/brush-train/src/train.rs b/crates/brush-train/src/train.rs
@@ -256,11 +256,9 @@ impl SplatTrainer {
 
             let _span = trace_span!("Calculate losses", sync_burn = true).entered();
 
-            // Convert to srgb space.
             let pred_rgb = pred_images
                 .clone()
-                .slice([0..batch_size, 0..img_h, 0..img_w, 0..3])
-                .clamp_min(0.0);
+                .slice([0..batch_size, 0..img_h, 0..img_w, 0..3]);
 
             // This is wrong if the batch has mixed transparent and non-transparent images,
             // but that's ok for now.