fixed stride fees and revenue #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akan72
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Looks good @limzhengjie thanks for the detailed test plan and congrats on the first PR!!
@Sunny77D once we can update the tooltips through the admin panel, maybe we mention that for Stride fees should = revenue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed stride fees from gasFees to fees (totalYield * 0.1)
strideFees = revenue
ez_stride_metrics materialized successfully
reverse_etl works successfully and data looks correct in the frontend
