Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding core directory to projects that were missing it #664

Merged
merged 1 commit into from
Dec 9, 2024
Merged

adding core directory to projects that were missing it #664

merged 1 commit into from
Dec 9, 2024

Conversation

alexwes
Copy link
Contributor

@alexwes alexwes commented Dec 9, 2024

Realized some projects were missing a core subdirectory. This could pose risk in the future if we treat models based on their exact file path and some ez tables are not in the core subdirectory.

@alexwes alexwes requested a review from a team as a code owner December 9, 2024 18:30
akan72
akan72 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@akan72 akan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexwes good catch! For now I think this is a safe change because we base the asset group on the end of the filepath

@alexwes alexwes merged commit e6afba7 into main Dec 9, 2024
3 checks passed
@alexwes alexwes deleted the wes/add-core-folder branch December 9, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akan72 akan72 akan72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwes @akan72