Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drift Parsed Logs Model #619

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add Drift Parsed Logs Model #619

merged 2 commits into from
Nov 14, 2024

Conversation

akan72
Copy link
Contributor

@akan72 akan72 commented Nov 14, 2024

📌 References

Compiled dedup logic correctly dedups for data that was written multiple times (ordering by float column and only one record appears)
image

🎄 Asset Checklist

  • Added to databases.csv or already exists

🧮 Metric Checklist

  • Added new fact tables if necessary
  • Pulled fact table into ez_asset_metrics.sql table
  • Compiles in Github
  • Show Changed Models in Github matches expectations for what metric value should be

@akan72 akan72 requested a review from a team as a code owner November 14, 2024 20:52
Copy link
Contributor

@Sunny77D Sunny77D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you ser. should we add some logic to handle duplicated data if we accidentally run a day twice?

@akan72
Copy link
Contributor Author

akan72 commented Nov 14, 2024

LGTM! Thank you ser. should we add some logic to handle duplicated data if we accidentally run a day twice?

Yup, I'll add this logic before shipping

@akan72 akan72 merged commit c9d7a96 into main Nov 14, 2024
3 checks passed
@akan72 akan72 deleted the feature/drift_perps branch November 14, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants