Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmo fees fix #600

Merged
merged 1 commit into from
Nov 8, 2024
Merged

osmo fees fix #600

merged 1 commit into from
Nov 8, 2024

Conversation

alexwes
Copy link
Contributor

@alexwes alexwes commented Nov 8, 2024

Quick fix to Osmo data that was causing below DQ issue:

Screenshot 2024-11-07 at 8 30 25 PM

Fix by filtering for any trader where the fee paid is > 1,000,000 USD.

Query compiles:
Screenshot 2024-11-07 at 8 32 55 PM

@alexwes alexwes requested a review from a team as a code owner November 8, 2024 01:30
Copy link
Contributor

@akan72 akan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexwes How can this happen, if somebody misconfigures a setting within their wallet? Or is it an upstream data quality issue

@alexwes
Copy link
Contributor Author

alexwes commented Nov 8, 2024

It is an issue with the upstream table osmosis_flipside.price.ez_prices which has decimals set to 0 for the token that is causing the issue.

This means coalesce(gas, 0) / pow(10, t2.decimal) as gas_adj evaluates to gas / pow(10,0) = gas.

@alexwes
Copy link
Contributor Author

alexwes commented Nov 8, 2024

Maybe better solution in that case is to filter where decimals > 0

@alexwes alexwes merged commit 6fa292a into main Nov 8, 2024
3 checks passed
@alexwes alexwes deleted the wes/osmo-fee-fix-clean branch November 8, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants