Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 10Q dbt models #593

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Add 10Q dbt models #593

merged 7 commits into from
Nov 8, 2024

Conversation

horaceliuHL
Copy link
Contributor

📌 References

🎄 Asset Checklist

  • Added to databases.csv or already exists

🧮 Metric Checklist

  • Added new fact tables if necessary
  • Pulled fact table into ez_asset_metrics.sql table
  • Compiles in Github
  • Show Changed Models in Github matches expectations for what metric value should be

@horaceliuHL horaceliuHL requested a review from a team as a code owner November 7, 2024 00:14
@horaceliuHL horaceliuHL marked this pull request as draft November 7, 2024 00:14
akan72
akan72 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@akan72 akan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🔥 🏦 🚀 🌔

models/staging/equities/__equities__source.yml Outdated Show resolved Hide resolved
akan72
akan72 reviewed Nov 7, 2024
View reviewed changes
models/projects/equities/ez_sec_gov_10q.sql Outdated
)
}}

select * from {{ ref("fact_sec_gov_10q") }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, if we want to include other metrics in the future we can do so in the ez_ table and then UNION ALL the various relations together

@horaceliuHL horaceliuHL marked this pull request as ready for review November 7, 2024 20:16
@horaceliuHL horaceliuHL merged commit a70c301 into main Nov 8, 2024
3 checks passed
@horaceliuHL horaceliuHL deleted the horace/add-sec-seed branch November 8, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akan72 akan72 akan72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horaceliuHL @akan72