-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alw joe v2 data #529
base: main
Are you sure you want to change the base?
Alw joe v2 data #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change
{{ | ||
config( | ||
materialized="table", | ||
snowflake_warehouse="TRADER_JOE", | ||
database="trader_joe", | ||
schema="core", | ||
alias="ez_metrics", | ||
) | ||
}} | ||
|
||
with | ||
v2_tvl as ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add a comment in the ez_metrics...
about the differences in the ez_metrics_by_chain
and the ez_metrics
model. If I remember from our convo ez_metrics_by_chain
does not include the v2 or greater data?
can you also add a note in ez_dex_swaps
?
Converting this PR to draft. Reasoning goes as follows:
We also learned that v2.0 Factory contract address has been made publicly available in the docs. This was new. Next steps are to remove the API extract logic and pull the data for v2.0 from the chain. |
PR Objectives:
ez_metrics
table that can be used in the outerlands index so as to not require additional logic to handleez_metrics_by_chain
Outcome:
ez_metrics
table is created, and works with the outerlands index logic, and has all versions datacoalesce
)ez_metrics_by_chain
does not include v2.0, 2.1, 2.2 data as we were missing v2.0, 2.1, 2.2 TVL by chain. Adding the rest of the v2+ metrics (dau, txns, fees) but not TVL would have resulted in a more confusing experience for the end user, especially Snowflake Share users and users of the sectors dashboard. Defillama does support TVL data for these protocol versions, but does not offer a 'by chain' breakdown, making it impossible to add to theez_metrics_by_chain
.Next steps would be to get Trader Joe TVL for v2+.
daily_trader_joe_job
runs successfully, materializingez_metrics
+by_chain
tables.