Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnosis rolling #481

Merged
merged 3 commits into from
Sep 12, 2024
Merged

gnosis rolling #481

merged 3 commits into from
Sep 12, 2024

Conversation

simon-weber-artemis
Copy link
Contributor

@simon-weber-artemis simon-weber-artemis commented Sep 11, 2024 •
edited
Loading

📌 References

🎄 Asset Checklist

  • Added to databases.csv or already exists

🧮 Metric Checklist

  • Added new fact tables if necessary
  • Pulled fact table into ez_asset_metrics.sql table
  • Compiles in Github
  • Show Changed Models in Github matches expectations for what metric value should be

@simon-weber-artemis simon-weber-artemis requested a review from a team as a code owner September 11, 2024 15:29
@Sunny77D
Copy link
Contributor

Do we have a ez_gnosis_metrics table set up??

Sunny77D
Sunny77D approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Sunny77D Sunny77D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your help simon! 🚢

@simon-weber-artemis simon-weber-artemis merged commit 80ab8e7 into main Sep 12, 2024
3 checks passed
@simon-weber-artemis simon-weber-artemis deleted the gnosis-rolling branch September 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunny77D Sunny77D Sunny77D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-weber-artemis @Sunny77D