Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Git Commit History #475

Merged
merged 213 commits into from
Sep 9, 2024
Merged

Update Git Commit History #475

merged 213 commits into from
Sep 9, 2024

Conversation

SebMelendez01
Copy link
Contributor

@SebMelendez01 SebMelendez01 commented Sep 9, 2024

This PR Fixes commit history that was requested to be changes. Ill merge tomorrow. The image below shows the fixed commit history.
Screenshot 2024-09-08 at 11 02 52 PM

Process:

  1. Get how many commits I need to go back: git rev-list --reverse --grep="****" HEAD | head -n 1 | xargs -I{} git rev-list --count {}..HEAD
  2. git rebase -i HEAD~213
  3. I then went through and changed pick to reword for all the prs that contained ****
  4. Git prompts me for each one to change the commit. and then i saved and pushed.

Testing:

  1. Checked to make sure none of the logs contain **** by running git log --grep="****"
  2. Contains the most recent commit: f337073
  3. Checked to make sure dasgter contains the most recent models
Screenshot 2024-09-09 at 11 22 45 AM Screenshot 2024-09-09 at 11 22 38 AM

SebMelendez01 and others added 30 commits September 8, 2024 22:46
@SebMelendez01 SebMelendez01 requested a review from a team as a code owner September 9, 2024 02:58
@SebMelendez01 SebMelendez01 changed the title Fix commit history Update Git Commit History to be more clear Sep 9, 2024
@SebMelendez01 SebMelendez01 changed the title Update Git Commit History to be more clear Update Git Commit History Sep 9, 2024
Copy link
Contributor

@akan72 akan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @SebMelendez01 thanks for verifying the model text in dagster. Another test that I did was to ensure that the file size of dbt and it's subdirectories matched between this branch and main:

See that the total size in bytes is identical

cd dbt
du -hs .
Pasted Graphic 8 total

@SebMelendez01 SebMelendez01 merged commit 67f49fd into main Sep 9, 2024
3 checks passed
@SebMelendez01 SebMelendez01 deleted the fix-commit-history branch September 9, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants