Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Defillama as its own project #459

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Added Defillama as its own project #459

merged 1 commit into from
Sep 3, 2024

Conversation

Sunny77D
Copy link
Contributor

@Sunny77D Sunny77D commented Sep 3, 2024 •
edited
Loading

📌 References

Added defillama as its own database so we can share defillama specific data via our snowflake data share.

🎄 Asset Checklist

  • Added to databases.csv or already exists

🧮 Metric Checklist

  • Added new fact tables if necessary
  • Pulled fact table into ez_asset_metrics.sql table
  • Compiles in Github
  • Show Changed Models in Github matches expectations for what metric value should be

@Sunny77D Sunny77D self-assigned this Sep 3, 2024
@Sunny77D Sunny77D requested a review from a team as a code owner September 3, 2024 20:49
akan72
akan72 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@akan72 akan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sunny77D Any particular reason for not including fees + revenues as well?

@Sunny77D
Copy link
Contributor Author

Sunny77D commented Sep 3, 2024

@Sunny77D Any particular reason for not including fees + revenues as well?

Yeah just because i dont people to confuse it with our fees + revs. Also defillama fees and revs can be really in accurate sometimes.

@Sunny77D Sunny77D merged commit 288852f into main Sep 3, 2024
3 checks passed
@Sunny77D Sunny77D deleted the son/add-defillama-database branch September 3, 2024 20:54
SebMelendez01 pushed a commit that referenced this pull request Sep 9, 2024
@Sunny77D @SebMelendez01
Added Defillama as its own project (#459)
f03ca3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akan72 akan72 akan72 approved these changes

Assignees

@Sunny77D Sunny77D

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sunny77D @akan72