Updating coingecko metadata #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akan72
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
@SebMelendez01 Do you have an estimate on how many coins we were dropping bc they were uncategorized? I imagine it's small and/or comprised of longer tail coins only
|
the old amount is 12,755 and the new amount is 14,638. The only coin we need that it is currently dropping is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the categories =
[]with a coingecko token it is not included in the coingecko metadata table because the CTE does not contain a row for that token (inner join). This causes our metadata table to not contain all the tokens that we extract from coingecko as well as not allow us to tag some tokens to apps in sigma. By using a left join we continue to support tokens that do not have an empty array for the categories.