Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alw add uniswap #387

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Alw add uniswap #387

merged 18 commits into from
Aug 13, 2024

Conversation

alexwes
Copy link
Contributor

@alexwes alexwes commented Aug 11, 2024

Added:

  • Token incentives
  • Treasury
  • Breakdowns by token
  • ez metrics table
  • tokenholder count macro

Modified existing Uniswap macros including fact_uniswap_v2_fork_dex_swaps.sql, fact_uniswap_v3_fork_dex_swaps, fact_uniswap_daily_metrics.sql.

Also added _usd to a a maker data model column name.

@alexwes alexwes requested a review from a team as a code owner August 11, 2024 22:32
SebMelendez01
SebMelendez01 requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@SebMelendez01 SebMelendez01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! A few things to change

macros/metrics/get_address_balance_by_token.sql Outdated Show resolved Hide resolved
macros/metrics/get_daily_tokenholder_count_flipside.sql Outdated Show resolved Hide resolved
models/projects/maker/prod_raw/fact_treasury_lp_balances.sql Show resolved Hide resolved
models/projects/uniswap/core/ez_uniswap_metrics.sql Outdated Show resolved Hide resolved
models/projects/uniswap/core/ez_uniswap_metrics_by_chain.sql Outdated Show resolved Hide resolved
models/projects/uniswap/core/ez_uniswap_metrics_by_pool.sql Outdated Show resolved Hide resolved
models/projects/uniswap/core/ez_uniswap_metrics_by_token.sql Outdated Show resolved Hide resolved
@alexwes alexwes enabled auto-merge (squash) August 13, 2024 02:55
@alexwes alexwes requested a review from SebMelendez01 August 13, 2024 02:56
SebMelendez01
SebMelendez01 reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@SebMelendez01 SebMelendez01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, then feel free to merge

macros/metrics/get_daily_tokenholder_count_flipside.sql Outdated Show resolved Hide resolved
@alexwes alexwes requested a review from SebMelendez01 August 13, 2024 14:26
SebMelendez01
SebMelendez01 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@SebMelendez01 SebMelendez01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwes alexwes merged commit cfcf73e into main Aug 13, 2024
3 checks passed
@alexwes alexwes deleted the alw_add_uniswap branch August 13, 2024 17:49
SebMelendez01 pushed a commit that referenced this pull request Sep 9, 2024
@alexwes @SebMelendez01
Alw add uniswap (#387)
2e3f3e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebMelendez01 SebMelendez01 SebMelendez01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwes @SebMelendez01