Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pip -> uv #247

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Switch from pip -> uv #247

merged 6 commits into from
Jun 25, 2024

Conversation

akan72
Copy link
Contributor

@akan72 akan72 commented Jun 24, 2024

Summary

  • Porting over pip commands to uv (github), a drop-in replacement package manager + dependency resolver in order to improve build performance
  • Use of a virtualenv is typically required, but the --system Astral/uv team mentions in the docs that doing a system-level install is fine within a CI environment
  • Increase # of threads used in the dbt compile step in CI from 4 -> 16

Test Plan

  • Executed commands locally
image
  • dbt is installed + commands work in the CI environment for this PR

@akan72 akan72 changed the title Update pip commands to use uv Switch from pip -> uv Jun 24, 2024
@akan72 akan72 marked this pull request as ready for review June 24, 2024 21:18
@akan72 akan72 requested a review from a team as a code owner June 24, 2024 21:18
pip install pip-tools==6.13.0
pip install -r requirements.txt
pip install uv==0.2.15
uv pip install pip==23.1.2 pip-tools==6.13.0 --system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, we don't use pip-compile or pip-sync in this repo anyway so it should be fine to remove.

pip should already be installed in the GH actions worker's system. But even if it isn't, uv can install for us which is p cool
image

@akan72 akan72 merged commit f24f508 into main Jun 25, 2024
3 checks passed
@akan72 akan72 deleted the feature/uv_build branch June 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants