Revamping the helm Chart and implementing CI/CD #271
Conversation
| containers: | ||
| - name: grpcurl | ||
| image: fullstorydev/grpcurl:v1.8.7-alpine | ||
| args: ['-plaintext', '{{ include "arroyo.fullname" . }}-api:{{ .Values.service.grpcPort }}','list'] |
There was a problem hiding this comment.
I think we'll need to change this to the HTTP endpoint now as the gRPC endpoint is gone in the API server; we might also want to test that the other services are up
There was a problem hiding this comment.
There was already a test for the HTTP endpoint, should this just be removed?
There was a problem hiding this comment.
oh, I see — I think this will need to be tweaked a bit as the API service no longer has a gRPC endpoint. So it will need to run only on the controller and compiler.
There was a problem hiding this comment.
This should address the problem with the services 554cab7 (#271)
I will submit a separate commit for the output dir
| containers: | ||
| - name: grpcurl | ||
| image: fullstorydev/grpcurl:v1.8.7-alpine | ||
| args: ['-plaintext', '{{ include "arroyo.fullname" . }}-api:{{ .Values.compiler.service.grpcPort }}','list'] |
There was a problem hiding this comment.
should this be -compiler (and below, -controller) instead of -api?
There was a problem hiding this comment.
Fixed with
af93b05 (#271)
This PR implements CI/CD testing for the helm chart and addresses a couple of bugs discovered along the way:
Unfortunately my fork has no access to the secrets, so I think for this reason it fails. In my local fork everything works fine edmondop#2