Final Updates for R4

[amsmith-pro]

No description provided.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don"t have @amsmith-pro on file. In order for us to review and merge your code, please visit https://www.arrowair.com/docs/contributing/cla and follow the instructions on the page to add yourself to the list.

[amsmith-pro]

In local-dev/docker-compose/aetheric-svc.yml the list of environment variables have a <SERVICE>_PORT_REST for each service with a REST server. However this variable is never used since the docker-compose.yml exposes the respective REST ports per service via ports: using the <SERVICE>_HOST_PORT_REST variable in the dotfile.

I assume then that <SERVICE>_PORT_REST is simply an empty string that isn't read by the program

[amsmith-pro]

Add a (commented) dozzle instance in the docker-compose.yaml for easier log perusal, extended timeouts for health checks otherwise certain services (like svc-storage and svc-gis) don't have long enough to start.

One slightly misleading log warning for multiple services is this:

Which is only because "Config::try_from_env" is being used, and in some instances it starts with creating a default:

[owlot]

In local-dev/docker-compose/aetheric-svc.yml the list of environment variables have a <SERVICE>_PORT_REST for each service with a REST server. However this variable is never used since the docker-compose.yml exposes the respective REST ports per service via ports: using the <SERVICE>_HOST_PORT_REST variable in the dotfile.

I assume then that <SERVICE>_PORT_REST is simply an empty string that isn't read by the program

I've done some testing and the environment configuration is indeed mostly redundant due to the already present .env file.
It can be replaced with this configuration:

    environment:
      - ASSETS_PORT_GRPC=${DOCKER_PORT_GRPC}
      - ATC_PORT_GRPC=${DOCKER_PORT_GRPC}
      - CARGO_PORT_GRPC=${DOCKER_PORT_GRPC}
      - COMPLIANCE_PORT_GRPC=${DOCKER_PORT_GRPC}
      - CONTACT_PORT_GRPC=${DOCKER_PORT_GRPC}
      - DISCOVERY_PORT_GRPC=${DOCKER_PORT_GRPC}
      - GIS_PORT_GRPC=${DOCKER_PORT_GRPC}
      - PRICING_PORT_GRPC=${DOCKER_PORT_GRPC}
      - SCHEDULER_PORT_GRPC=${DOCKER_PORT_GRPC}
      - STORAGE_PORT_GRPC=${DOCKER_PORT_GRPC}
      - TELEMETRY_PORT_GRPC=${DOCKER_PORT_GRPC}

[amsmith-pro]

In local-dev/docker-compose/aetheric-svc.yml the list of environment variables have a <SERVICE>_PORT_REST for each service with a REST server. However this variable is never used since the docker-compose.yml exposes the respective REST ports per service via ports: using the <SERVICE>_HOST_PORT_REST variable in the dotfile.
I assume then that <SERVICE>_PORT_REST is simply an empty string that isn't read by the program

I've done some testing and the environment configuration is indeed mostly redundant due to the already present .env file. It can be replaced with this configuration:

    environment:
      - ASSETS_PORT_GRPC=${DOCKER_PORT_GRPC}
      - ATC_PORT_GRPC=${DOCKER_PORT_GRPC}
      - CARGO_PORT_GRPC=${DOCKER_PORT_GRPC}
      - COMPLIANCE_PORT_GRPC=${DOCKER_PORT_GRPC}
      - CONTACT_PORT_GRPC=${DOCKER_PORT_GRPC}
      - DISCOVERY_PORT_GRPC=${DOCKER_PORT_GRPC}
      - GIS_PORT_GRPC=${DOCKER_PORT_GRPC}
      - PRICING_PORT_GRPC=${DOCKER_PORT_GRPC}
      - SCHEDULER_PORT_GRPC=${DOCKER_PORT_GRPC}
      - STORAGE_PORT_GRPC=${DOCKER_PORT_GRPC}
      - TELEMETRY_PORT_GRPC=${DOCKER_PORT_GRPC}

706d5b0