Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous updates and updates to documents #206

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 23, 2024

Major Changes in this PR

  • AFC-28 Added ability to change stepper current when printing
  • AFC-25 Added a boolean flag to PREP so that TCMD assignment does not happens twice in a single restart
  • AFC-29 Added a check during prep load to make sure print is not printing,homing or moving as this would normally crash klipper
  • Added comments to configuration variables to help aid in auto documentation of config variables
  • Added features document to put features of AFC. Added bypass, print current and ram sensor to this document.

Notes to Code Reviewers

How the changes in this PR are tested

Testing results from trying to load printer when homing/moving
image

Testing for setting different current

Tool load:
    // Tool Change - None -> leg1
    // Loading leg1
    // Run Current: 0.61A Hold Current: 0.61A Home Current: 0.80A          # First sync to extruder for people using a toolhead sensor
    // Run Current: 0.80A Hold Current: 0.80A Home Current: 0.80A          # Unsync to extruder for ramming
    // Run Current: 0.61A Hold Current: 0.61A Home Current: 0.80A          # Sync back to extruder once ramming is done
    // New rotation distance after applying factor: 5.222222222222222
    // TURTLENECK buffer enabled
    // leg1 is now loaded in toolhead

PREP - Current is set to print current to lane that is loaded into toolhead
    // Run Current: 0.61A Hold Current: 0.61A Home Current: 0.80A
    // LEG1 tool cmd: T0  LOCKED AND LOADED in ToolHead

Tool unload
    // Unloading leg1
    // AFC_Cut: Cut Filament
    // AFC_Park: Park Toolhead z_safe: 14.0
    // Run Current: 0.80A Hold Current: 0.80A Home Current: 0.80A       # Unsyncing from extruder for buffer retract
    // Run Current: 0.80A Hold Current: 0.80A Home Current: 0.80A       # Unsyncing from extruder for long retract

Prep being called again after prep being automatically ran does not output error

image

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 23, 2024 23:29
- Added ability to set tmc current between printing and loading
- Added helper function to sync and unsync to extruder
- Changing sync and unsync to use stepper helper functions
- AFC-29 Adding check to make sure printer is not moving when loading filament, displays error message to user
- AFC-25 Added a boolean flag so that TCMD macros don't try to get reassigned when users manually run prep after prep has automatically ran
- Added comments for each variable that can be configured
- Added features document to cover misc features found in AFC
- Added trsync commented out to default config file
@MG-longshot MG-longshot merged commit 0ba9287 into ArmoredTurtle:DEV Dec 24, 2024
1 check passed
@jimmyjon711 jimmyjon711 deleted the change_current branch December 24, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants