Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update so printer does not issue pause when ejecting filament #184

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Update so printer does not issue pause when ejecting filament #184

merged 1 commit into from
Dec 11, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 11, 2024 •
edited
Loading

Major Changes in this PR

  • Setting lane status to ejecting and making sure status is not ejecting when going into infinite spool and pause logic

Notes to Code Reviewers

How the changes in this PR are tested

Pause is not issued when spools are ejected

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 11, 2024 03:13
MG-longshot
MG-longshot reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@MG-longshot MG-longshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MG-longshot MG-longshot merged commit 9c860e6 into ArmoredTurtle:DEV Dec 11, 2024
1 check passed
@jimmyjon711 jimmyjon711 deleted the pause_fix branch December 14, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MG-longshot MG-longshot MG-longshot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjon711 @MG-longshot