Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFC-21 Fixing error state and adding pause when prep goes false #178

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

jimmyjon711
Copy link
Contributor

@jimmyjon711 jimmyjon711 commented Dec 10, 2024

Major Changes in this PR

  • Fixing error state, error state will only be set to true when a pause is commanded. Made sure error state and pause variables get reset back to false when resume is called.
  • Added logic to pause print when prep sensor goes false
  • Had to add a check to make sure runout_lane was not blank
  • Fixed other errors where functions were not referencing self.AFC

Notes to Code Reviewers

How the changes in this PR are tested

Tested with short filament so that it caused prep to de-active when filament passed the sensor

PR Checklist: (Checked-off items are either done or do not apply to this PR)

  • I have performed a self-review of my code
  • CHANGELOG.md is updated (if end-user facing)
  • Sent notification to software-design channel requesting review

@jimmyjon711 jimmyjon711 marked this pull request as ready for review December 10, 2024 03:29
@jimmyjon711 jimmyjon711 changed the title Fixing error state and adding pause when prep goes false AFC-21 Fixing error state and adding pause when prep goes false Dec 10, 2024
@MG-longshot
Copy link
Collaborator

i see no issues

@MG-longshot MG-longshot self-requested a review December 10, 2024 03:32
@MG-longshot MG-longshot merged commit 18e9ee1 into ArmoredTurtle:DEV Dec 10, 2024
1 check passed
@jimmyjon711 jimmyjon711 deleted the error_state_fix branch December 10, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants