Add Go linter rules

.github/workflows/main.yml

@@ -27,7 +27,7 @@ jobs:
         uses: golangci/golangci-lint-action@v6
         with:
           version: latest
-          args: "--verbose --print-issued-lines --print-linter-name --out-${NO_FUTURE}format colored-line-number --timeout 300s --max-issues-per-linter 0 --max-same-issues 0"
+          args: "--print-issued-lines --print-linter-name --out-${NO_FUTURE}format colored-line-number --timeout 300s --max-issues-per-linter 0 --max-same-issues 0"
 
       - name: Test Go
         run: go test ./... --cover

.golangci.yaml

@@ -0,0 +1,34 @@
+run:
+  timeout: 10m
+
+linters:
+  disable-all: true # Disable defaults, then enable the ones we want
+  enable:
+  - unused
+  - errcheck
+  - gosimple
+  - govet
+  - ineffassign
+  - staticcheck
+  - typecheck
+  - unused
+  - bodyclose
+  - stylecheck
+  - gosec
+  - goimports
+  - gci
+  - revive
+  - gocritic
+  - unconvert
+
+linters-settings:
+  goimports:
+    local-prefixes: github.com/ArmDeveloperEcosystem
+  gci:
+    sections:
+    - Standard
+    - Default
+    - Prefix(github.com/ArmDeveloperEcosystem)
+  testifylint:
+    # Enable all checkers (https://github.com/Antonboom/testifylint#checkers).
+    enable-all: true

changes/18.misc

@@ -0,0 +1 @@
+Add Go linter rules

cmd/images.go

@@ -21,9 +21,10 @@ import (
 	"log"
 	"sort"
 
+	"github.com/spf13/cobra"
+
 	"github.com/ArmDeveloperEcosystem/kubearchinspect/internal/images"
 	"github.com/ArmDeveloperEcosystem/kubearchinspect/internal/k8s"
-	"github.com/spf13/cobra"
 )
 
 const (
@@ -40,58 +41,55 @@ var imagesCmd = &cobra.Command{
 	Run:   imagesCmdRun,
 }
 
-func imagesCmdRun(cmd *cobra.Command, args []string) {
-	debug, err := cmd.Flags().GetBool("debug")
-	if err != nil {
-		log.Fatal(err)
-	}
+func imagesCmdRun(_ *cobra.Command, _ []string) {
 
 	k8sClient, err := k8s.NewKubernetesClient()
 	if err != nil {
 		log.Fatal(err)
 	}
+
 	imageList, err := k8sClient.GetAllImages()
 	if err != nil {
 		log.Fatal(err)
 	}
-	fmt.Printf("Legend:\n-------\n%s - arm64 supported\n%s - arm64 supported (with update)\n%s - arm64 not supported\n%s - error occurred\n", successIcon, upgradeIcon, failedIcon, errorIcon)
-	fmt.Print("------------------------------------------------------------------------------------------------\n\n")
+
+	fmt.Printf(
+		"Legend:\n-------\n%s - arm64 supported\n%s - arm64 supported (with update)\n%s - arm64 not supported\n%s - error occurred\n%s",
+		successIcon,
+		upgradeIcon,
+		failedIcon,
+		errorIcon,
+		"------------------------------------------------------------------------------------------------\n\n",
+	)
 
 	sort.Strings(imageList)
 	for _, image := range imageList {
-		var icon string
-		supportsArm, err := images.CheckLinuxArm64Support(image)
-		if err != nil {
-			if debug {
+		var (
+			icon             string
+			supportsArm, err = images.CheckLinuxArm64Support(image)
+		)
+
+		switch {
+		case err != nil:
+			if debugEnabled {
 				fmt.Printf("error: %s\n", err)
 			}
 			icon = errorIcon
-		} else if supportsArm {
+		case supportsArm:
 			icon = successIcon
-		} else {
+		default:
 			latestSupportsArm, _ := images.CheckLatestLinuxArm64Support(image)
 			if latestSupportsArm {
 				icon = upgradeIcon
 			} else {
 				icon = failedIcon
 			}
 		}
+
 		fmt.Printf("%s %s\n", icon, image)
 	}
 }
 
 func init() {
 	rootCmd.AddCommand(imagesCmd)
-
-	imagesCmd.Flags().BoolP("debug", "d", false, "Enable debug mode")
-
-	// Here you will define your flags and configuration settings.
-
-	// Cobra supports Persistent Flags which will work for this command
-	// and all subcommands, e.g.:
-	// imagesCmd.PersistentFlags().String("foo", "", "A help for foo")
-
-	// Cobra supports local flags which will only run when this command
-	// is called directly, e.g.:
-	// imagesCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
 }

cmd/root.go

@@ -22,6 +22,8 @@ import (
 	"github.com/spf13/cobra"
 )
 
+var debugEnabled bool
+
 var rootCmd = &cobra.Command{
 	Use:   "kubearchinspect",
 	Short: "Check how ready your Kubernetes cluster is to run on Arm.",
@@ -36,13 +38,5 @@ func Execute() {
 }
 
 func init() {
-	// Here you will define your flags and configuration settings.
-	// Cobra supports persistent flags, which, if defined here,
-	// will be global for your application.
-
-	// rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.kubearchinspect.yaml)")
-
-	// Cobra also supports local flags, which will only run
-	// when this action is called directly.
-	// rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
+	rootCmd.PersistentFlags().BoolVarP(&debugEnabled, "debug", "d", false, "Enable debug mode")
 }