Improved usage of DirectoryInfo in SystemFolder #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, SystemFolder is not properly making use of lazy-loading for DirectoryInfo (`Info` property).
Arlodotexe
approved these changes
Jun 20, 2024
Arlodotexe
added a commit
that referenced
this pull request
Jun 20, 2024
Update release notes in `src/OwlCore.Storage.csproj` for version 0.11.2 to include fixes from PR #57. - Adds a new entry under `<PackageReleaseNotes>` detailing the fix for the issue where `SystemFolder` was not properly utilizing lazy-loading for `DirectoryInfo` (`Info` property) when only the path is available. This complements the existing note about fixing synchronous operations in `File.Open`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Arlodotexe/OwlCore.Storage/pull/59?shareId=c896c4b6-1e78-463d-a433-260f2bfe7187).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SystemFolder is not properly making use of lazy-loading for DirectoryInfo (
Infoproperty) when we only have the path. In some use cases having the directory info pre-loaded can be unnecessary and slows down performance especially when enumerating large folders.