Merge pull request #71 from Arlodotexe/fix/httpfile/large-files

Fixed reading files larger than 2GB with HttpFile
Arlodotexe · Sep 7, 2024 · 49609e0 · 49609e0
2 parents d68f9b4 + a12f4bb
commit 49609e0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 191 deletions.
diff --git a/src/Internal/LazySeekStream.cs b/src/Internal/LazySeekStream.cs
diff --git a/src/OwlCore.Storage.csproj b/src/OwlCore.Storage.csproj
@@ -23,6 +23,13 @@
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIcon>logo.png</PackageIcon>
     <PackageReleaseNotes>
+--- 0.12.0 ---
+[Breaking]
+The Stream opened from HttpFile is no longer seekable, as the internal LazySeekStream and all usages have been removed.
+
+[Fixes]
+Fixes an issue where files larger than 2GB couldn't be fully read via HttpFile.
+
 --- 0.11.3 ---
 [Improvement]
 Removed redundant validation when enumerating files and folders to improve performance in SystemFile and SystemFolder.

diff --git a/src/System/Net/Http/HttpFile.cs b/src/System/Net/Http/HttpFile.cs
@@ -89,10 +89,9 @@ public async Task<Stream> OpenStreamAsync(FileAccess accessMode = FileAccess.Rea
         // Extract the content length if available
         long? length = response.Content.Headers.ContentLength;
 
-        if (length is long notNullLength)
+        if (length is { } notNullLength)
             contentStream = new LengthOverrideStream(contentStream, notNullLength);
 
-        // Return in a lazy seek-able wrapper.
-        return new LazySeekStream(contentStream);
+        return contentStream;
     }
 }