Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain stream types #761

Closed
wants to merge 1 commit into from
Closed

Conversation

WayneManion
Copy link

Add a list of allowed stream types. I thought this was valuable because the stream types are not explained in this document. I had to look in the fluidd codebase to find a list of valid values. The valid values are not the same as the options shown in the fluidd webUI.

https://github.com/fluidd-core/fluidd/blob/999ccddd1a39d6037ec6a8f34b689b0216ea592d/src/components/settings/cameras/CameraConfigDialog.vue#L86

Signed-off-by: Wayne Manion [email protected]

Add a list of allowed stream types. I thought this was valuable because the stream types are not explained in this document. I had to look in the fluidd codebase to find a list of valid values. The valid values are not the same as the options shown in the fluidd webUI.

https://github.com/fluidd-core/fluidd/blob/999ccddd1a39d6037ec6a8f34b689b0216ea592d/src/components/settings/cameras/CameraConfigDialog.vue#L86
@bakatrouble
Copy link
Contributor

bakatrouble commented Dec 11, 2023

I personally added a custom stream type support to Mainsail a while ago, and from I understand, Moonraker does not "allow" any specific values, it just stores a string value there for frontends to use, which could be absolutely random.

@Arksine
Copy link
Owner

Arksine commented Dec 12, 2023

@bakatrouble is correct. This available stream types are determined by the frontend and not constrained by Moonraker. It is probably best to simply direct users to the front end's documentation as is noted in the paragraph preceding the example.

@WayneManion
Copy link
Author

I get what you're saying. It isn't Moonraker's job to tell what cameras the front ends can support.

Here is fluidd's documentation on cameras.

Here is Mainsail's camera docs.

Neither one of them documents anything about how to specify the camera settings through moonraker.conf. I don't think a user should have to dig through source code to find the list of strings needed for a particular type of camera to work. Maybe the solution is more thorough documentation of fluidd and Mainsail.

@Arksine
Copy link
Owner

Arksine commented Dec 27, 2023

I took a more detailed look at this and agree that Moonraker's documentation needs to provide more guidance here. The frontend documentation explains how to configure webcams through their interfaces, but abstracts the underlying values.

I have updated the webcam documentation to include tables for known icon and service values.

@WayneManion
Copy link
Author

That is awesome! Thanks for the thorough and helpful documentation.

@Arksine
Copy link
Owner

Arksine commented Dec 28, 2023

Thanks. I'll go ahead and close this as resolved.

@Arksine Arksine closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants