Added support for systems without gpio or not suppoting the "python3-libgpiod" lib #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The change itself looks ok, however the install script is intended for standard Debian distros and derivatives. One goal is to keep the installer as straight forward as possible so it can be used as a template for custom installations. Therefore I don't think its appropriate to merge this change. At some point in the future I will likely write a more robust installer in Python intended to support more distros and obscure derivatives. |
|
Ok I understand, I am closing the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's my first contribution ever so please don't judge me too much,
I use the project on an android tv box which I installed armbian on and the installer couldn't install the "python3-libgpiod" lib and failed, So i added a check on the "install-mooneraker.sh" script to check if the "python3-libgpiod" apt package is installable if it is it runs the install process normally and if it isn't it skips the installation of the "python3-libgpiod" package by installing the packages from the file "system-dependencies-without-gpio.json" I added instead of the "system-dependencies.json" file.