Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve infinite loop in _white_list_collection #244

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

JoE11-y
Copy link
Contributor

@JoE11-y JoE11-y commented Sep 30, 2024

Added missing line issue causing the issue where the admin was unable to remove certain collections. Added a unit test to verify correct behavior and prevent future regressions.

Resolves #230

Copy link

vercel bot commented Sep 30, 2024

@JoE11-y is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

@JoE11-y JoE11-y requested a review from ptisserand October 1, 2024 11:36
Copy link
Collaborator

@ptisserand ptisserand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some minor changes and it should be good to be merged

apps/blockchain/starknet/src/tests/bridge_t.cairo Outdated Show resolved Hide resolved
apps/blockchain/starknet/src/tests/bridge_t.cairo Outdated Show resolved Hide resolved
@JoE11-y JoE11-y requested a review from ptisserand October 1, 2024 16:01
@JoE11-y JoE11-y requested a review from ptisserand October 2, 2024 06:52
Copy link
Collaborator

@ptisserand ptisserand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!
LGTM

@ptisserand ptisserand added this pull request to the merge queue Oct 2, 2024
Merged via the queue into ArkProjectNFTs:main with commit acb3cb1 Oct 2, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin won't be able to remove certain collections from the whitelist on L2
2 participants