Retrieve L1 deposit transaction price #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethereum price is provided by Moralis with WETH uniswap v3
|
@ptisserand is attempting to deploy a commit to the Screenshot Team on Vercel. A member of the Team first needs to authorize it. |
remiroyc
reviewed
Apr 17, 2024
| let gas = self.client.get_tx_fees(&e.tx_hash).await?; | ||
| let eth_price = self | ||
| .pricer | ||
| .get_price("0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2", None) |
There was a problem hiding this comment.
C'est le même contract address sur sepolia (pour eth) ?
There was a problem hiding this comment.
Moralis fournit le prix d'un token en s'appuyant sur uniswap v3 (mainnet) et c'est l'adresse du WETH.
Lorsque l'indexeur tourne sur sepolia, il recevra toujours le prix du WETH de la pool uniswap, ça ne devrait pas poser de soucis.
remiroyc
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add transaction price (in USD) for
DepositInitiatedL1event.Ethereum price is provided by Moralis (WETH on Uniswap v3)