Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sg ensure #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/sg ensure #5

wants to merge 3 commits into from

Conversation

rdkls
Copy link

@rdkls rdkls commented Jul 12, 2018

Delete / recreate SG each time
Ideally wouldn't delete if not necessary .. however wanted to be sure that if IP changed the SG got updated

@ArjenSchwarz
Copy link
Owner

This breaks when you call the endpoint a second time when you have the container running as the security group is attached to the ENI so it can't be deleted. A similar solution that would work is looping over the existing ingress rules and deleting those before adding the current incoming IP. Keep in mind that one use case of the Lambda function is to get the IP of the bastion, which is especially important when the creation timed out due to AWS being slower than usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants