Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rebuild dependancies #233

Merged
merged 3 commits into from
Sep 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove false positive isMounted lint rule
mikeldking committed Sep 12, 2024
commit 0d46ce0eacb5a66e2885a1f4a46bae69f1812307
4 changes: 4 additions & 0 deletions src/notification/Notification.tsx
Original file line number Diff line number Diff line change
@@ -85,7 +85,9 @@ export class Notification extends Component<
this.add = this.add.bind(this);
this.remove = this.remove.bind(this);
}

add(noticeConfig: NoticeConfig) {
// eslint-disable-next-line react/no-is-mounted
this.setState({
notices: [
...this.state.notices,
@@ -98,6 +100,7 @@ export class Notification extends Component<
}

remove(id: string) {
// eslint-disable-next-line react/no-is-mounted
this.setState({
notices: this.state.notices.filter(notice => notice.id !== id),
});
@@ -120,6 +123,7 @@ export class Notification extends Component<
<Notice
key={notice.id}
{...notice}
// eslint-disable-next-line react/no-is-mounted
onClose={() => this.remove(notice.id)}
/>
</CSSTransition>

Unchanged files with check annotations Beta

<ListBoxSection
key={reusableView.key}
item={reusableView.content}
layoutInfo={reusableView.layoutInfo!}

Check warning on line 115 in src/listbox/ListBoxBase.tsx

GitHub Actions / Build, lint, and test on Node 18.x and ubuntu-latest

Forbidden non-null assertion

Check warning on line 115 in src/listbox/ListBoxBase.tsx

GitHub Actions / Build, lint, and test on Node 18.x and windows-latest

Forbidden non-null assertion

Check warning on line 115 in src/listbox/ListBoxBase.tsx

GitHub Actions / Build, lint, and test on Node 18.x and macOS-latest

Forbidden non-null assertion
virtualizer={reusableView.virtualizer}
// @ts-ignore
headerLayoutInfo={
function Radio(props: RadioProps) {
const radioGroupProps = useRadioProvider();
const { state } = radioGroupProps!;

Check warning on line 63 in src/radio/Radio.tsx

GitHub Actions / Build, lint, and test on Node 18.x and ubuntu-latest

Forbidden non-null assertion

Check warning on line 63 in src/radio/Radio.tsx

GitHub Actions / Build, lint, and test on Node 18.x and windows-latest

Forbidden non-null assertion

Check warning on line 63 in src/radio/Radio.tsx

GitHub Actions / Build, lint, and test on Node 18.x and macOS-latest

Forbidden non-null assertion
const {
variant = 'default',
size = 'normal',
`}
>
{typeof children === 'function'
? children({ isSelected, index: index! })

Check warning on line 264 in src/tabs/Tabs.tsx

GitHub Actions / Build, lint, and test on Node 18.x and ubuntu-latest

Forbidden non-null assertion

Check warning on line 264 in src/tabs/Tabs.tsx

GitHub Actions / Build, lint, and test on Node 18.x and windows-latest

Forbidden non-null assertion

Check warning on line 264 in src/tabs/Tabs.tsx

GitHub Actions / Build, lint, and test on Node 18.x and macOS-latest

Forbidden non-null assertion
: children}
</div>
);