Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move off of tsdx and related tooling #32

Merged

Conversation

cephalization
Copy link
Collaborator

@cephalization cephalization commented Nov 13, 2024

Resolves #31

  • Remove direct tsdx, babel, jest, tslib deps
  • Install vite, vitest, plugins
  • Configure vite and vitest
  • Update github workflows to use pnpm and node 20

TODO:

  • Upgrade storybook, install storybook vite plugin
  • Test new dist files in external project, ensure usage/imports remain the same

- Remove direct tsdx, babel, jest, tslib deps
- Install vite, vitest, plugins
- Configure vite and vitest
- Update github workflows to use pnpm and node 20
@cephalization
Copy link
Collaborator Author

cephalization commented Nov 20, 2024

It would be helpful to implement https://github.com/stackblitz-labs/pkg.pr.new for this PR so that we can test npm installs of point cloud from other apps:

  • Are imports well-typed
  • Are all desired files included in the pkg download
  • Does esm vs cjs detection work correctly during import

@mikeldking
Copy link
Contributor

very cool - we should do a test publish.

LGTM tho

@cephalization cephalization marked this pull request as ready for review December 6, 2024 01:42
@cephalization
Copy link
Collaborator Author

Published @arizeai/[email protected] / @arizeai/[email protected] and installed it in phoenix as well as another project with no issues. Imports are well typed and no runtime errors occur.

vite.config.ts Outdated Show resolved Hide resolved
vite.config.ts Show resolved Hide resolved
@cephalization cephalization merged commit edf9af9 into Arize-ai:main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: move off of tsdx
2 participants