feat: llama-index instrumentor using callback handler #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
axiomofjoy
reviewed
Jan 19, 2024
|
|
||
| resource = Resource(attributes={}) | ||
| tracer_provider = trace_sdk.TracerProvider(resource=resource) | ||
| span_exporter = OTLPSpanExporter(endpoint="http://127.0.0.1:6006/v1/traces") |
There was a problem hiding this comment.
Is there a simple way for the user to see the contents of the exported trace or span in this example?
There was a problem hiding this comment.
There's the in-memory-exporter. but that's kind of advanced usage. On the other hand the examples are meant to demonstrate phoenix as a collector.
There was a problem hiding this comment.
There's no Phoenix instance running as a collector in these examples, though, and they should probably be independent of Phoenix.
Small nit, would just be nice if there is a simple collector we could run to display the spans as they come in.
There was a problem hiding this comment.
good point. probably worth a group discussion on how to do that
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Show resolved
Hide resolved
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Show resolved
Hide resolved
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Outdated
Show resolved
Hide resolved
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Outdated
Show resolved
Hide resolved
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Show resolved
Hide resolved
axiomofjoy
reviewed
Jan 19, 2024
...erence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/__init__.py
Show resolved
Hide resolved
...erence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/__init__.py
Show resolved
Hide resolved
...instrumentation-llama-index/tests/openinference/instrumentation/llama_index/test_callback.py
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Outdated
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Outdated
Show resolved
Hide resolved
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Show resolved
Hide resolved
…ex/src/openinference/instrumentation/llama_index/_callback.py Co-authored-by: Xander Song <[email protected]>
axiomofjoy
approved these changes
Jan 19, 2024
|
Do we have type checking turned on in the unit tests? That would be nice. |
anticorrelator
approved these changes
Jan 21, 2024
...rence-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_callback.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Arize-ai/phoenix#1957
based on the callback handler from Phoenix