Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): Make llm.system and llm.provider available from LLMAttributePostfixes #1135

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix(js): Make llm.system and llm.provider available from LLMAttributePostfixes #1135

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5263e
fix(js): Make llm.system and llm.provider available from LLMAttribute…
cephalization Nov 25, 2024
99b59d9
Changeset
cephalization Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions js/packages/openinference-semantic-conventions/src/trace/SemanticConventions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ export const SemanticAttributePrefixes = {
} as const;

export const LLMAttributePostfixes = {
provider: "provider",
system: "system",
model_name: "model_name",
token_count: "token_count",
input_messages: "input_messages",
Expand Down Expand Up @@ -165,12 +167,13 @@ export const LLM_MODEL_NAME =
* The provider of the inferences. E.g. the cloud provider
*/
export const LLM_PROVIDER =
`${SemanticAttributePrefixes.llm}.provider` as const;
`${SemanticAttributePrefixes.llm}.${LLMAttributePostfixes.provider}` as const;

/**
* The AI product as identified by the client or server
*/
export const LLM_SYSTEM = `${SemanticAttributePrefixes.llm}.system` as const;
export const LLM_SYSTEM =
`${SemanticAttributePrefixes.llm}.${LLMAttributePostfixes.system}` as const;

/** Token count for the completion by the llm */
export const LLM_TOKEN_COUNT_COMPLETION =
Expand Down
Loading