Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dspy): instrument dspy rather than dspy-ai #1113

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Nov 12, 2024

DSPy seems to have two packages, dspy and dspy-ai. The latter installs the former, and the former now seems to be the recommended way to install the package in the docs. This change should support both. Also makes flaky test less strict.

resolves #1111

@axiomofjoy axiomofjoy marked this pull request as ready for review November 12, 2024 04:45
@axiomofjoy axiomofjoy requested a review from a team as a code owner November 12, 2024 04:45
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 12, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@axiomofjoy axiomofjoy changed the title fix(dspy): migrate test to new litellm error fix(dspy): make dspy test less strict Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@axiomofjoy axiomofjoy changed the title fix(dspy): make dspy test less strict fix(dspy): instrument dspy rather than dspy-ai and make dspy test less strict Nov 12, 2024
@axiomofjoy axiomofjoy changed the title fix(dspy): instrument dspy rather than dspy-ai and make dspy test less strict fix(dspy): instrument dspy rather than dspy-ai Nov 12, 2024
@axiomofjoy axiomofjoy merged commit 5f6e149 into main Nov 12, 2024
6 checks passed
@axiomofjoy axiomofjoy deleted the xander/fix-dspy branch November 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] dspy instrumentor failing CI unit tests for the latest dspy version
2 participants