Arize dev/workload identity support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not error out if when we find our credentials they did not come from a json file containing a gcp service account. For workload identity FindDefaultCredentials() will not fill in the creds.JSON field but rather will attach a creds.TokenSource directly that can be used by storage.NewClient().
We leave s.signedURLOptions empty which does not seem to affect the operation of SignGet() function at top of the file.
This was tested to operate on an on-prem test cluster. As store_gcs.go is not used by the arize gazette consumers we did not have to change the arize go.mod file to pick up this change. Only the gazette broker needs a new image.