Support shared key credentials with blob SAS in latest store_azure.go #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest gazette azure changes upstream they changed store_azure.go SignGet() to work with user delegated credentials (UDC) and Container SAS storage. This change allows us to run with a shared key and Blob SAS as we used to do. The current upstream is a little inconsistent i believe as azureClient() routine seems to work with shared keys or UDC but the SignGet() only works with one.
This change might not be accepted upstream as we are opinionated that an azure:// scheme is for shared keys (this may be ok) but it works with Blob SAS as opposed to Container SAS (maybe that should be another level of choice).