Skip to content

Commit

Permalink
better logging
Browse files Browse the repository at this point in the history
  • Loading branch information
ddowker committed Jun 6, 2024
1 parent 1ce9c0e commit 5dea541
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions broker/client/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ func (r *Reader) Read(p []byte) (n int, err error) {
return 0, err

}
log.WithFields(log.Fields{
"url": fmt.Sprintf("%+v", fragURL),
"fragment": fmt.Sprintf("%+v", *r.Response.Fragment),
}).Warn("reader handle url")
if fragURL.Scheme != "gs" {
return 0, fmt.Errorf("TransformSignedURLs is only supported for GCS")
}
Expand Down
4 changes: 2 additions & 2 deletions broker/fragment/store_gcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ func (s *gcsBackend) SignGet(ep *url.URL, fragment pb.Fragment, d time.Duration)

if DisableSignedUrls {
log.WithFields(log.Fields{
"ep": fmt.Sprintf("%v", *ep),
"fragment": fmt.Sprintf("%v", fragment),
"ep": fmt.Sprintf("%+v", *ep),
"fragment": fmt.Sprintf("%+v", fragment),
}).Info("signGet disable signed urls")
u := &url.URL{
Path: fmt.Sprintf("/%s/%s", cfg.bucket, cfg.rewritePath(cfg.prefix, fragment.ContentPath())),
Expand Down

0 comments on commit 5dea541

Please sign in to comment.