Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't define ARDUINO=100 if already defined as something else #179

Closed
wants to merge 3 commits into from
Closed

Don't define ARDUINO=100 if already defined as something else #179

wants to merge 3 commits into from

Conversation

jgfoster
Copy link
Member

Fixes #176

jgfoster pushed a commit to jgfoster/arduino_ci that referenced this pull request Oct 12, 2020
Tests now pass (with PR Arduino-CI#179).
e60f962
This was referenced Oct 16, 2020
Closed
Closed
@jgfoster
Copy link
Member Author

For the reasons discussed here, it seems that #185 would be a better approach.

@jgfoster jgfoster closed this Oct 27, 2020
@jgfoster jgfoster deleted the cmd_line_defines branch November 4, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARDUINO=100 always added as define to g++
1 participant
@jgfoster