Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

VRBRAIN: changed some cmake files for building with waf #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

VRBRAIN: changed some cmake files for building with waf #63

wants to merge 2 commits into from

Conversation

LukeMike
Copy link

Some updates to allow building of VRBRAIN boards with waf

  • added informations of USB driver to allow uploader
  • added CPU configuration of the boards

@@ -513,6 +513,54 @@ function(px4_os_add_flags)
-mthumb
-march=armv7-m
)
elseif (${BOARD} STREQUAL "vrbrain-v51")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to do it that way? You could use elseif (${BOARD} MATCHES "vrbrain-.*"), no?

@LukeMike
Copy link
Author

Hi @guludo I done it that way because also other boards are listed separately even if they have the same CPU. But if you prefere I can change it

@guludo
Copy link

guludo commented Aug 12, 2016

Hi,

On Fri, Aug 12, 2016 at 3:13 AM Luca Angelo Micheletti <
[email protected]> wrote:

Hi @guludo https://github.com/guludo I done it that way because also
other boards are listed separately even if they have the same CPU. But if
you prefere I can change it

I think they should be separated only if there's a big chance of changing
those parameters in a near future.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvzi4SLkZ9SdAS05wFdbw_F_T_PEO-Xks5qfA8ggaJpZM4JiPju
.

@OXINARF
Copy link
Member

OXINARF commented Aug 12, 2016

@guludo I agree with you, but Luca has a point: if it is done that way for the other boards there's no reason for VRBRAIN boards to be different - we should try to maintain consistency.

@tridge
Copy link

tridge commented Aug 17, 2016

if they are all the same cpu options then MATCHES makes sense I think

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants