Change default archive audio format to FLAC 24bit #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, so I think this is a better default because it does not lose as much dynamic range in case one accidentally just pressed "OK" in the archive dialog without double checking the options every damn time (currently always resets to FLAC 16bit)
Although this is not perfect yet in another case:
The archive feature currently reencodes ALL audio files of a project. So if one set the project format to FLAC 16bit but makes an archive in FLAC 24bit, the archive can become larger than the original project directory
So to improve on that, Ardour should check files before encoding and only encode those where it makes sense. It should skip re-encoding into the same format or if the original file has the same codec but lower bit-depth
This can be implemented in another PR. I tried but failed for now. So if anyone else wants to work on that (or help me out), feel free to do so