Commits on Oct 18, 2017

1. A better method for "Close Regions Gaps" …

   The actual method for "Close Region Gaps" can be improved.
   Indeed, in the current code, each region is stretched of "pull back length" to the left,
   the region on the left is stretched to overlap this one of "Fade Length".
   The problem arises when using this method after split a region at onsets and snap to grid all new regions (Rhytme ferret).
   If after "split at Onsets", a gap between two regions is bigger than "Pull Back Length", then the right region will be stretched of Pull Back Lenght to the left, and the left region will be stretched to the right until overlap the right one. And what can we ear on the right side of the left region ? The attack present at the beggining of the right region.
   
   To avoid this, I propose this code which retains the same behavior except that it never stretch the left region to the right. If the left region is not close enought, the right one will be stretched to the left until the end of the left one. This avoids double attacks.
   
   So, we can rename "Pull Back Length", in "Minimum Pull Back Lenght" and set it by defaut to 10ms instead of 30ms, by experience it seems reasonable for drums or guitars.
   
   Also, the code I propose uses truely the fade duration defined by user instead of a simple overlap (for audio regions only). If "Fade Length" is set on 0ms, the default fade will be used (64samples), I think it's good the set it to 0 by default.
   
   To test this, take an audio region of rhytmic guitar or drum, apply Rhytme Ferret, analyze region, split region at Onsets, select all new regions and "snap to grid". Then use "Close Gaps".

   

   Houston4444 authored Oct 18, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 948472c
   • Browse repository at this point

   Copy the full SHA

   948472c View commit details

   Browse the repository at this point in the history