-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Scale Feature for Mobs with Levels #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/dev/aurelium/auramobs/util/ScaleUtil.java
Archy-X
requested changes
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency in code style and to follow best practice, I've made comments mostly about removing static fields and methods.
src/main/java/dev/aurelium/auramobs/commands/AuraMobsCommand.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the requested feature in #9 . Mobs can now have different sizes based on two valid entries:
50-100: chance: 0.5 scale: 1-2
This allows mobs between the levels 50-100 to have a 50% of being between the sizes 1 and 2. The other option is:
10-100: chance: 1.0 scale: 1, 2, 3
This allows mobs between the levels 1-100 to have the sizes 1, 2 or 3.
For the code, the functionality is handled over a new class called ScaleUtil that has a method to load the config and also apply the scale. With this, the config can easily be reloaded by the reload command and API-Access for applying the scale is also given. The class also holds a private inner class called ScaleEntry that holds all values.
Further, all entries are stored in a LinkedList, so they are stored on a linear basis which allows later entries to perhaps override entities with a smaller chance to a different size.
As discussed on Discord, the PR also contains the change for the PlaceholderAPI repo.
Lmk if there is something change
I also append screenshots of blazes using the feature as well as a spider once which naturally spawned
PS: Yes, I've messed up a commit due to debug outputs