Stardew Vallet Tests - Restructure the tests that validate Mods + ER together, improved performance #4557
+54
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Discord Convo between Black Sliver and myself starts here: https://discord.com/channels/731205301247803413/1214608557077700720/1333158359632969810
Short version is:
Buildings
)Final improvement is about 65% on that one specific test, that took about 15 seconds out of the 90s test run. So globally, for stardew tests on my machine, it's nearly 10% improvement, probably better when multithreaded
How was this tested?
How do you think lmao
If this makes graphical changes, please attach screenshots.
Before:
After: