Hollow Knight: update item name groups #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft at the moment because I dont know if the names are what is wanted |
ScootyPuffJr1
added
the
is: refactor/cleanup
BadMagic100
suggested changes
Oct 27, 2023
|
This would resolve #2214 by the way, let's see if GitHub will link it lol |
kindasneaki
commented
Oct 27, 2023
|
Yep looks good to me |
BadMagic100
approved these changes
Oct 28, 2023
black-sliver
approved these changes
Oct 28, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
* add missing groups * remove set comprehensions * fix boss essence * reorganized them * combine boss essence on creation instead of update * rename to match option names * Add missing groups * add PoP totem
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
* add missing groups * remove set comprehensions * fix boss essence * reorganized them * combine boss essence on creation instead of update * rename to match option names * Add missing groups * add PoP totem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adding in missing item name groups and fixing the names of the ones that were currently there.
How was this tested?
ran webhost and looked at the datapackage