Skip to content

Commit

Permalink
Laser Misc Changes (shiptest-ss13#3879)
Browse files Browse the repository at this point in the history
## About The Pull Request

Makes ordinary lasers / eguns normal sized instead of bulky, and lets
you add both them and weapon cells to holsters. Also fixes a singular
weapon sprite on Singulo Lab.

Fixes shiptest-ss13#3790

## Why It's Good For The Game

They look like they're handguns and they should fit in holsters too

## Changelog

:cl:
balance: Lasers / Eguns are now normal-sized
add: Lasers / Eguns now fit in holsters
fix: Sprite issue on Singulo Lab lasercannons

/:cl:

---------

Co-authored-by: github-actions <[email protected]>
  • Loading branch information
generalthrax and actions-user authored Dec 12, 2024
1 parent 561a0cb commit a97bc3e
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
4 changes: 2 additions & 2 deletions _maps/RandomRuins/SpaceRuins/singularity_lab.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -9118,7 +9118,7 @@
/obj/effect/gibspawner,
/obj/item/gun/energy/lasercannon{
desc = "An advanced laser cannon, a laser etched inscription in the handle states 'NT-LS-1013'. The casing is made of a lightweight alloy.";
icon_state = "pulse";
icon_state = "lasercannon";
name = "NT-LS-1013"
},
/turf/open/floor/plating/asteroid,
Expand Down Expand Up @@ -10922,7 +10922,7 @@
/obj/machinery/light/directional/north,
/obj/item/gun/energy/lasercannon{
desc = "An advanced laser cannon, a laser etched inscription in the handle states 'NT-LS-1013'. The casing is made of a lightweight alloy.";
icon_state = "pulse";
icon_state = "lasercannon";
name = "NT-LS-1013"
},
/obj/item/gun/energy/laser/iot,
Expand Down
7 changes: 5 additions & 2 deletions code/datums/components/storage/concrete/pockets.dm
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,12 @@
can_hold = typecacheof(list(
/obj/item/gun/ballistic/automatic/pistol,
/obj/item/gun/ballistic/revolver,
/obj/item/ammo_box))
/obj/item/gun/energy/laser,
/obj/item/gun/energy/e_gun,
/obj/item/stock_parts/cell/gun,
/obj/item/ammo_box)) // this doesnt let you put hades into holsters trust me
can_hold_max_of_items = typecacheof(list(
/obj/item/gun/ballistic = 1
/obj/item/gun = 1,
))

/datum/component/storage/concrete/pockets/holster/real_location()
Expand Down
4 changes: 3 additions & 1 deletion code/modules/projectiles/guns/energy/energy_gun.dm
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
dual_wield_spread = 60
wield_slowdown = LASER_RIFLE_SLOWDOWN
manufacturer = MANUFACTURER_SHARPLITE_NEW
w_class = WEIGHT_CLASS_BULKY
w_class = WEIGHT_CLASS_NORMAL

/obj/item/gun/energy/e_gun/empty_cell
spawn_no_ammo = TRUE
Expand Down Expand Up @@ -50,6 +50,7 @@
default_ammo_type = /obj/item/stock_parts/cell/gun/upgraded

weapon_weight = WEAPON_MEDIUM
w_class = WEIGHT_CLASS_BULKY
slot_flags = ITEM_SLOT_BACK

gun_firemodes = list(FIREMODE_SEMIAUTO, FIREMODE_FULLAUTO)
Expand Down Expand Up @@ -241,6 +242,7 @@
item_state = "shotgun_combat"
shaded_charge = TRUE
ammo_type = list(/obj/item/ammo_casing/energy/disabler/scatter/ultima, /obj/item/ammo_casing/energy/laser/ultima)
w_class = WEIGHT_CLASS_BULKY
var/obj/item/modular_computer/integratedNTOS
var/NTOS_type = /obj/item/modular_computer/internal

Expand Down
6 changes: 4 additions & 2 deletions code/modules/projectiles/guns/energy/laser.dm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "SL L-204 laser gun"
desc = "A basic energy-based laser gun that fires concentrated beams of light which pass through glass and thin metal."

w_class = WEIGHT_CLASS_BULKY
w_class = WEIGHT_CLASS_NORMAL
custom_materials = list(/datum/material/iron=2000)
ammo_type = list(/obj/item/ammo_casing/energy/lasergun)
ammo_x_offset = 1
Expand Down Expand Up @@ -129,6 +129,7 @@
item_state = null
ammo_type = list(/obj/item/ammo_casing/energy/xray)
ammo_x_offset = 3
w_class = WEIGHT_CLASS_BULKY

////////Laser Tag////////////////////

Expand Down Expand Up @@ -171,6 +172,7 @@
icon_state = "iotshotgun"
item_state = "shotgun_combat"
ammo_type = list(/obj/item/ammo_casing/energy/disabler/scatter/ultima)
w_class = WEIGHT_CLASS_BULKY
var/obj/item/modular_computer/integratedNTOS
var/NTOS_type = /obj/item/modular_computer/internal
manufacturer = MANUFACTURER_SHARPLITE_NEW
Expand Down Expand Up @@ -202,7 +204,6 @@
item_state = "gun"
ammo_x_offset = 2
charge_sections = 4
w_class = WEIGHT_CLASS_NORMAL
default_ammo_type = /obj/item/stock_parts/cell/gun/mini
allowed_ammo_types = list(
/obj/item/stock_parts/cell/gun/mini,
Expand Down Expand Up @@ -253,6 +254,7 @@
)
ammo_type = list(/obj/item/ammo_casing/energy/laser/eoehoma/e50)
weapon_weight = WEAPON_HEAVY
w_class = WEIGHT_CLASS_BULKY
manufacturer = MANUFACTURER_EOEHOMA

wield_delay = 0.7 SECONDS
Expand Down

0 comments on commit a97bc3e

Please sign in to comment.