Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to assigning type to redaction search results #1021

Open
wants to merge 1 commit into
base: 8.12
Choose a base branch
from

Conversation

kanderson91
Copy link

The webviewer assigns a type to each redaction search result by iterating through all the patterns and seeing which one matches the result text. I was running into some problems with this so I made the following changes:

-Keep track of which patterns are in the current search so that we only have to iterate through those.
-If the user is doing a search for just one pattern, always assign the type of that pattern to each search result.
-When checking if a pattern matches the search result, use the ambient text instead of just the result string.

That last change is useful when using patterns with lookarounds in them. For example, say the user adds this custom pattern to match any string of digits preceded by "ID:"
(?<=ID:\s)\d+

Then say the page has the text "ID: 123" and so we get a search result with "123". In the current logic, the system will check if (?<=ID:\s)\d+ matches "123" and find that it does not. So I changed it to check if it matches the ambient text "ID: 123".

@bollain
Copy link
Collaborator

bollain commented Jun 13, 2023

Hey @kanderson91, thanks for taking the time to make this PR! We are reviewing it internally and will let you know once this is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants