Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to neostandard and eslint@9 #1665

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .eslintrc.json

This file was deleted.

1 change: 0 additions & 1 deletion .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
custom:
- https://github.com/sponsors/eslint
- https://github.com/sponsors/standard
- https://donate.mozilla.org/
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ All pull requests must be compatible with the repository license (GPL-3.0).

### Style guide

[![js-semistandard-style](https://raw.githubusercontent.com/standard/semistandard/master/badge.svg)](https://github.com/standard/semistandard)

This project follows JavaScript Semi-Standard Style via [`eslint-config-semistandard`](https://github.com/standard/eslint-config-semistandard).
This project follows JavaScript Standard Style with semicolons via [`neostandard`](https://github.com/neostandard/neostandard).

Stylesheets should aim to follow Nicolas Gallagher's [Idiomatic CSS](https://github.com/necolas/idiomatic-css#readme) principles. Additionally, element classnames and IDs should be `kebab-case`, to fit with the automatic casing of [`data-*` attributes](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/data-*).

Expand Down
29 changes: 29 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import neostandard, { plugins, resolveIgnoresFromGitignore } from 'neostandard';
import globals from 'globals';
import jsdoc from 'eslint-plugin-jsdoc';

export default [
...neostandard({
globals: {
...globals.browser,
...globals.es2021,
...globals.webextensions,
...globals.jquery
},
semi: true,
ignores: [...resolveIgnoresFromGitignore(), 'src/lib/*']
}),
jsdoc.configs['flat/recommended'],
{
rules: {
...plugins['import-x'].flatConfigs.recommended.rules,
'import-x/no-cycle': 'error'
}
},
{
files: ['src/main_world/*'],
rules: {
'jsdoc/require-jsdoc': 'off'
}
}
];
Loading
Loading