Indicate and disable currently-outdated features #1660
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eh, I mean, it's an idea.
This implements the ability to mark a feature as outdated and completely nonfunctional in the metadata. Outdated scripts aren't run even if enabled* and are marked visually in the preferences popup. This might make sense for a feature we expect to be outdated (only) in the short term; I feel like it's better than hiding the feature and having people wonder if they imagined it existing this whole time.
Related: #1526, which uses the "deprecation" mechanism to make a outdated feature not appear to new users until it's back to functioning correctly (particularly makes sense for long-term-outdated features). Probably makes sense to implement an overarching strategy addressing both of these things, maybe with a single flag; I haven't fully thought it through.
*currently not true if you toggle them on, or off and on; I guess I'd need to refactor to fix this
Testing steps