New Feature: Sidebar Blogs #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
force-pushed
the
sidebar-blogs
branch
from
b3dfbc2 to
ad1c039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a (spiritual?) successor to the blog avatars added by classic XKit's Header Blogs extension, this feature adds all of the user's blogs to the new desktop layout left sidebar. This reduces the number of clicks required to get to e.g. a certain blog's drafts by one.
In the full-width desktop view, this is done by moving the fully-functional blogs list element out of the account dropdown menu entirely using CSS trickery. Shoutout to nightpool for using
display: contentsin a feature draft and clueing me in to its existence. In narrower views, we don't have anything to move, so a more traditional route of adding icons and styling them to have proper on-hover effects is taken. The mobile drawer is not affected.Note that sidebar icons change size/padding when a touchscreen is detected, and this has style tweaks for that mode; use browser dev tools responsive mode to see those tweaks.
This could certainly be argued as a tweak. I'd hear those arguments. But I think it's worth bringing up the idea of making it a feature, particularly as in theory it could have preferences (turning on/off the functionality in different widths, for example), and I wouldn't want to move it out of tweaks at some future point.
Testing steps