Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks: Improve badge hiding tweak reliability #1622

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

marcustyphoon
Copy link
Collaborator

Description

This improves the badge-hiding tweaks by:

  • removing reliance on translation strings that have multiple possible translation values in selectors (checked via https://gist.github.com/marcustyphoon/5cffac5d1c480603696e777632943f3a), ensuring they work in all UI languages
  • adding li to selectors missing them, an oversight that made them not apply to the mobile menu
  • adding an alternative href attribute used for the old (pre-vertical-nav) dashboard, in case anyone is still running that

Resolves #1461.

Testing steps

Confirm that the notification badge hiding tweaks work:

  • in all page widths of the regular desktop layout
  • in the mobile layout menu tray

@marcustyphoon
Copy link
Collaborator Author

adding an alternative href attribute used for the old (pre-vertical-nav) dashboard, in case anyone is still running that

Not sure if this code was just removed from Tumblr, but I can't be bothered to check :D

@marcustyphoon marcustyphoon merged commit 96b599a into AprilSylph:master Oct 27, 2024
2 checks passed
@marcustyphoon marcustyphoon deleted the badge-hide-selectors branch October 27, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweaks: Activity badge tweak broken in Chinese (Taiwan)
2 participants