Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors in console during queue rearranging #1617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

Description

Clicking and dragging a post in your queue to rearrange it (either in the queue "channel" page or in patio) generates a ghost post that will throw errors if our react data getters are called on it. Well, technically that's inaccurate; the thing that's created that would be accurately referred to as a "ghost" post is fine; the post that errors is the "fallback" post. Yes, I read the sortablejs readme; no it didn't make it at all clear to me which element is which. Whatever.

Anyway, this excludes the post in question from triggering onNewPosts handlers.

Resolves #1070.

Testing steps

  • Click and drag to rearrange a queued post on https://www.tumblr.com/blog/[blogname]/queue. Confirm that no errors appear in the javascript console.
  • Click and drag to rearrange a queued post on tumblr patio. Confirm that no errors appear in the javascript console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in console during queue rearranging (minor)
1 participant