AccessKit Disable Gifs: Minor code refactoring #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
requested changes
Apr 29, 2024
Ooh. Never like seeing that. |
marcustyphoon
commented
Apr 29, 2024
AprilSylph
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should result in no functional changes. Just some cleanup and refactoring I did before experimenting with the Disable Gifs code.
In a script with this many classnames I find it easier to use css-in-js so you don't lose track of them all.
Testing steps
https://www.tumblr.com/search/gif
Test Disable Gifs in a post with a gif photoset and in the tag search sidebar on the community header and suggested tag previews.